Skip to content

refactor(libanki): continue removing AnkiDroid dependencies from TestClass #18860

Merged
BrayanDSO merged 3 commits intoankidroid:mainfrom
david-allison:libanki-testclass-2
Jul 12, 2025
Merged

refactor(libanki): continue removing AnkiDroid dependencies from TestClass #18860
BrayanDSO merged 3 commits intoankidroid:mainfrom
david-allison:libanki-testclass-2

Conversation

@david-allison
Copy link
Member

I split this out from #18813 to make it an easier review

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Into a general extension method on `Collection`

in order to split out `TestClass` to libanki:testutils
in order to split out `TestClass` to libanki:testutils
@david-allison david-allison changed the title refactor(libanki): begin removing AnkiDroid dependencies from TestClass refactor(libanki): continue removing AnkiDroid dependencies from TestClass Jul 12, 2025
@BrayanDSO BrayanDSO added this pull request to the merge queue Jul 12, 2025
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Jul 12, 2025
Merged via the queue into ankidroid:main with commit 40a7c9f Jul 12, 2025
12 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 12, 2025
@github-actions github-actions bot added this to the 2.22 release milestone Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants